Re: [PATCH] x86: sparse errors from string_32.h

From: Ingo Molnar
Date: Fri Feb 01 2008 - 05:56:52 EST



* Harvey Harrison <harvey.harrison@xxxxxxxxx> wrote:

> case 1:
> - *(unsigned char *)s = pattern;
> + *(unsigned char *)s = pattern & 0xff;

i've applied your fix - but wouldnt it be cleaner to just cast the
pattern variable to unsigned char instead?

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/