Re: [PATCH 2/3] x86: add function prototype to vm86.h

From: Harvey Harrison
Date: Sat Feb 02 2008 - 03:27:53 EST


On Sat, 2008-02-02 at 16:14 +0800, Li Zefan wrote:
> Harvey Harrison åé:
> > Global functions should include their prototypes.
> >
> > Signed-off-by: Harvey Harrison <harvey.harrison@xxxxxxxxx>
> > ---
> > include/asm-x86/vm86.h | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/include/asm-x86/vm86.h b/include/asm-x86/vm86.h
> > index a5edf51..b72b9a6 100644
> > --- a/include/asm-x86/vm86.h
> > +++ b/include/asm-x86/vm86.h
> > @@ -195,6 +195,7 @@ struct kernel_vm86_struct {
> >
> > void handle_vm86_fault(struct kernel_vm86_regs *, long);
> > int handle_vm86_trap(struct kernel_vm86_regs *, long, int);
> > +struct pt_regs * save_v86_state(struct kernel_vm86_regs *);
> >
>
> This fixes a sparse warning, but contribute to a coding style error.
> checkpatch.pl complains about this patch.

Bugger, thought I caught that. Hopefully Ingo will delete the extra
space when applying, otherwise I'll send a replacement.

My apologies,

Harvey


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/