Re: [rft] s2ram wakeup moves to .c, could fix few machines

From: Rafael J. Wysocki
Date: Tue Feb 05 2008 - 20:58:51 EST


On Wednesday, 6 of February 2008, H. Peter Anvin wrote:
> Rafael J. Wysocki wrote:
> >> The asm() for making beeps really need to be moved to a function and
> >> cleaned up (redone in C using inb()/outb()) if they are to be retained
> >> at all.
> >
> > Yes, they are. For some people they're the only tool to debug broken resume.
>
> That's fine, but they should get cleaned up.

I 100% agree.

> /me is tempted to provide a version which can send messages in Morse Code ;)

That would be great. It could also play some music or something. ;-)

Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/