Re: [PATCH] ipvs: Make wrr "no available servers" error messagerate-limited

From: Simon Horman
Date: Tue Feb 05 2008 - 21:19:26 EST


On Tue, Feb 05, 2008 at 09:30:21PM +0100, Sven Wegener wrote:
> No available servers is more an error message than something informational. It
> should also be rate-limited, else we're going to flood our logs on a busy
> director, if all real servers are out of order with a weight of zero.
>
> Signed-off-by: Sven Wegener <sven.wegener@xxxxxxxxxxx>

Hi Sven,

this looks good to me.

Acked-by: Simon Horman <horms@xxxxxxxxxxxx>

> ---
>
> Actually, do we need this message at all? The wrr scheduler is the only one
> printing an error message in such a case.

I was wondering about that too. Though I'd err on the side of adding
it to the other schedulers as neccessary rather than removing it here.
But if you'd rather just get rid of it, I have no strong objections.

--
Horms

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/