Re: [PATCH] x86_32: fix regression caused by trim ram according tomtrr on system with 4G more RAM

From: Ingo Molnar
Date: Wed Feb 06 2008 - 04:51:43 EST



* Yinghai Lu <Yinghai.Lu@xxxxxxx> wrote:

> [PATCH] x86_32: fix regression caused by trim ram according to mtrr on system with 4G more RAM
>
> Pravel report:
> "
> The commit
>
>         093af8d7f0ba3c6be1485973508584ef081e9f93
>         x86_32: trim memory by updating e820
>
> broke my e1000 card: on loading driver says that
>
>         e1000: probe of 0000:04:03.0 failed with error -5
>
> and the interface doesn't appear.
> "
>
> on 32 bit kernel, base will overflow when try to do PAGE_SHIFT. and
> highest_addr will always less 4G.
>
> so use pfn instead of address to avoid overflow when more than 4g
> ram installed on 32bit kernel
> Many thanks for Pavel Emelyanov to report and test it.

thanks guys, applied.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/