[-mm PATCH] sysdev_unregister() should call kobject_del()

From: Badari Pulavarty
Date: Thu Feb 07 2008 - 18:54:21 EST


Hi Greg,

While playing with hotplug memory remove on 2.6.24-mm1, I
noticed that /sysfs directory entries are not getting removed.

sysdev_unregister() used to call kobject_unregister().
But in 2.6.24-mm1, its only dropping the ref. It should
call kobject_del() to remove the object. Correct ?

With this change, the directories are getting removed
correctly. Comments ?

Thanks,
Badari

sysdev_unregister() should call kobject_del() to remove
the object.

Signed-off-by: Badari Pulavarty <pbadari@xxxxxxxxxx>
---
drivers/base/sys.c | 1 +
1 file changed, 1 insertion(+)

Index: linux-2.6.24/drivers/base/sys.c
===================================================================
--- linux-2.6.24.orig/drivers/base/sys.c 2008-02-05 09:56:56.000000000 -0800
+++ linux-2.6.24/drivers/base/sys.c 2008-02-07 15:38:17.000000000 -0800
@@ -265,6 +265,7 @@ void sysdev_unregister(struct sys_device
}
mutex_unlock(&sysdev_drivers_lock);

+ kobject_del(&sysdev->kobj);
kobject_put(&sysdev->kobj);
}



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/