Re: [PATCH] mm/slub.c - Use print_hex_dump

From: Christoph Lameter
Date: Fri Feb 08 2008 - 13:32:54 EST


On Fri, 8 Feb 2008, Joe Perches wrote:

> On Fri, 2008-02-08 at 10:07 -0800, Christoph Lameter wrote:
> > On Fri, 8 Feb 2008, Joe Perches wrote:
> > > Use the library function to dump memory
> > Could you please compare the formatting of the output before and
> > after? Last time we tried this we had issues because it became a bit ugly.
>
> The difference is the last line of the ascii is not aligned
> if the length is non modulo 16.
>
> I have sent a patch to print_hex_dump to always align.
> http://lkml.org/lkml/2007/12/6/304

Could you group these together for review? I think we are okay with the
slub changes if the print_hex_dump is fixed.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/