Re: [PATCH 1/1] mxser: convert large macros to functions

[Jiri Slaby]

On 02/08/2008 10:41 PM, Andrew Morton wrote:
> On Fri,  8 Feb 2008 10:16:48 +0100
> Jiri Slaby <jirislaby@xxxxxxxxx> wrote:
>
> > From: Christoph Hellwig <hch@xxxxxx>
> >
> > From: Christoph Hellwig <hch@xxxxxx>
> >
> > Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> > Acked-by: Jiri Slaby <jirislaby@xxxxxxxxx>
>
> This should have been Signed-off-by: - you were in the delivery path.
>
> I'll make that change.
>
> > --- a/drivers/char/mxser.c
> > +++ b/drivers/char/mxser.c
>
> Has this been runtime tested?

Not by me, only compiled, sparsed, checkpatched and reviewed on my side (hence 
the ack).

> > -	DISABLE_MOXA_MUST_ENCHANCE_MODE(io);
> > +	mxser_disable_must_enchance_mode(io);
>
> hm, what's all this "enchance" stuff throughout the driver?  Did it mean
> "enhance"?

I have no idea. It seems so.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/