Re: [PATCH] Prevent IDE boot ops on NUMA system in mainline

From: Andi Kleen
Date: Mon Feb 11 2008 - 13:29:47 EST


On Mon, Feb 11, 2008 at 09:37:18AM -0800, Linus Torvalds wrote:
>
>
> On Mon, 11 Feb 2008, Linus Torvalds wrote:
> >
> > So we should probably make pcibus_to_node() be an inline function for that
> > case
>
> Or, we could just do the ugliest patch ever, namely
>
> -#define pcibus_to_node(node) (-1)
> +#define pcibus_to_node(node) ((int)(long)(node),-1)
>
> Wow. It's so ugly it's almost wraps around and comes out the other sides
> and looks pretty.

(void)arg, ... is better. Trick originally from Jan Beulich I think
(his code is always a good source for useful new C tricks)

-Andi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/