Re: [PATCH 1/2] acer-wmi - Fail gracefully if ACPI is disabled

From: Carlos Corbacho
Date: Tue Feb 12 2008 - 14:32:08 EST


On Tuesday 12 February 2008 04:41:42 Linus Torvalds wrote:
>
> On Mon, 11 Feb 2008, Carlos Corbacho wrote:
> >
> > WMI drivers, like their ACPI counterparts, should also check if ACPI is
> > disabled or not, and bail out if so, otherwise we cause a crash.
>
> Shouldn't "wmi_has_guid()" just return false if ACPI isn't enabled, and
> the drivers should just then always give up?

Yes - that's a better fix.

-Carlos
--
E-Mail: carlos@xxxxxxxxxxxxxxxxxxx
Web: strangeworlds.co.uk
GPG Key ID: 0x23EE722D
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/