Re: [RFC v3 4/7] dmaengine: Add slave DMA interface

From: Dan Williams
Date: Wed Feb 13 2008 - 14:07:45 EST


On Feb 12, 2008 9:43 AM, Haavard Skinnemoen <hskinnemoen@xxxxxxxxx> wrote:
[..]
> /**
> + * struct dma_slave_descriptor - extended DMA descriptor for slave DMA
> + * @async_tx: async transaction descriptor
> + * @client_node: for use by the client, for example when operating on
> + * scatterlists.
> + */
> +struct dma_slave_descriptor {
> + struct dma_async_tx_descriptor txd;
> + struct list_head client_node;
> +};

Can you explain a bit why client_node is needed? I do not think we
need dma_slave_descriptor if dma_unmap data / control is added to
dma_async_tx_descriptor. Hmm?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/