Re: [PATCHSET] printk: implement printk_header() and mergingprintk, take #3

From: Andrew Morton
Date: Wed Feb 13 2008 - 20:12:59 EST


On Thu, 14 Feb 2008 09:40:51 +0900
Tejun Heo <htejun@xxxxxxxxx> wrote:

> Can you please take a look at ata_eh_link_report() in
> drivers/ata/libata-eh.c?

I did. Punishment?

> Currently, it has some problems.

Yes, and the patches do clean that up.

ho hum. What tends to happen with this sort of thing is that fi we merge
it, it ends up getting used more often than one expected...


If you stand back and squint at it, there are quite a few places where we
do this sort of thing: allocate a buffer, squirt characters into it,
reallocating and/or flushing as we proceed. All sysfs and procfs read-side
code, for a start...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/