Re: [Openipmi-developer] [PATCH 3/4] IPMI: convert locked counters toatomics

[Corey Minyard]

Peter Zijlstra wrote:
> On Thu, 2008-02-14 at 12:30 -0600, Corey Minyard wrote:
>
>   
> > +/* The command didn't have anyone waiting for it. */
> > +#define IPMI_STAT_unhandled_commands			23
> > +
> > +/* Invalid data in an event. */
> > +#define IPMI_STAT_invalid_events			24
> > +
> > +/* Events that were received with the proper format. */
> > +#define IPMI_STAT_events				25
> > +
> > +/* When you add a statistic, you must update this value. */
> > +#define IPMI_NUM_STATS					26
> >     
>
> This shouts enum to me..
>   
Someone else asked about this, and I wasn't too sure.  It seems from the 
CodingStyle document that enums are preferred for things like this, but 
I current kernel code seems a mixed bag.  An enum is cleaner and more 
reliable, IMHO.  I'll convert it, I think.

Thanks,

-corey
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/