Re: [PATCH 2/3] WDEV, ath5k, don't return int from bool function

From: Luis R. Rodriguez
Date: Fri Feb 15 2008 - 17:08:24 EST


On Fri, Feb 15, 2008 at 3:58 PM, Jiri Slaby <jirislaby@xxxxxxxxx> wrote:

> -static bool
> +static int
> ath5k_hw_setup_xr_tx_desc(struct ath5k_hw *ah, struct ath5k_desc *desc,
> unsigned int tx_rate1, u_int tx_tries1, u_int tx_rate2, u_int tx_tries2,
> unsigned int tx_rate3, u_int tx_tries3)
> @@ -3773,10 +3773,10 @@ ath5k_hw_setup_xr_tx_desc(struct ath5k_hw *ah, struct ath5k_desc *desc,
>
> #undef _XTX_TRIES
>
> - return true;
> + return 1;
> }
>
> - return false;
> + return 0;
> }

Shouldn't we then treat 0 as OK?

Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/