Re: [lm-sensors] [PATCH] adt7473: New driver for Analog DevicesADT7473 sensor chip

From: Darrick J. Wong
Date: Mon Feb 18 2008 - 16:32:54 EST


On Sun, Feb 17, 2008 at 03:02:50PM -0500, Mark M. Hoffman wrote:

> Documentation/hwmon/adt7473 would be nice.

Ok, I'll generate one.

> That should be const.

Applied.

> > + BUG();
>
> Given ADT7473_PWM_BHVR_SHIFT is 5, this BUG() is obviously impossible.
> But I guess it's not obvious to GCC.

I'll put in a comment to explain that.

> NACK on that comment and associated code: Jean Delvare submitted a
> patch to NVIDIA over two years ago to fix their bug. Apparently some
> distros even carry his patch. So, I don't want to encourage such a
> hack to persist. Please just do the standard check here.

Ok. I wonder if the nouveau people have any intention to
reverse-engineer the i2c controller?

Updated patch to follow soon.

--D
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/