Re: [PATCH] x86: define outb_pic and inb_pic to stop using outb_pand inb_p

[Ingo Molnar]

* David P. Reed <dpreed@xxxxxxxx> wrote:

> x86: define outb_pic and inb_pic to stop using outb_p and inb_p
>  
> The delay between io port accesses to the PIC is now defined using 
> outb_pic and inb_pic.  This fix provides the next step, using 
> udelay(2) to define the *PIC specific* timing requirements, rather 
> than on bus-oriented timing, which is not well calibrated.

thanks David, applied.

minor nit:

> +	/* delay for some accesses to PIC on motherboard or in chipset must be
> +	   at least one microsecond, but be safe here. */

i changed this to the standard multi-line comment style of:

> +	/*
> +      * Delay for some accesses to PIC on motherboard or in chipset 
> +      * must be at least one microsecond, but be safe here:
> +      */

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/