Re: [PATCH] viocons: BKL locking

From: Alan Cox
Date: Thu Feb 21 2008 - 06:01:21 EST


On Thu, 21 Feb 2008 14:58:29 +1100
Paul Mackerras <paulus@xxxxxxxxx> wrote:

> Alan Cox writes:
>
> > For some weird reason I can't ascertain (translation "I think its
> > broken") the viocons driver calls directly into the n_tty ldisc code even
> > if another ldisc is in use. It'll probably break if you do that but I'm
> > just fixing the locking and adding a comment that its horked.
>
> Looks to me like it (viotty_ioctl) should return -ENOIOCTLCMD instead
> of calling n_tty_ioctl -- do you agree?

I think that is probably what is intended. That would then bounce back
throuh the tty layer to the right places.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/