Re: [PATCH] X86: remove WARN_ON if MTRRs are all blank

[Ingo Molnar]

* Joerg Roedel <joerg.roedel@xxxxxxx> wrote:

> > >  	if (!highest_pfn) {
> > >  		printk(KERN_WARNING "WARNING: strange, CPU MTRRs all blank?\n");
> > > -		WARN_ON(1);
> > >  		return 0;
> > >  	}
> > 
> > instead of obscuring a possibly useful warning, please instead 
> > detect that it's a KVM guest and skip both the warning and the 
> > backtrace in that case.
> 
> How usefull is the backtrace in that place? I agree that the printk 
> warning may be usefull, but I don't see why the backtrace from the 
> WARN_ON is necessary.

it allows us to collect such things on kerneloops.org for example.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/