Re: 2.6.24.2: 4KSTACKS + pcdrw + dm + mount -> stack overflow:ide-cd related? dm-related?

From: Ingo Molnar
Date: Tue Feb 26 2008 - 06:30:20 EST



* Jiri Kosina <jkosina@xxxxxxx> wrote:

> + name = kmalloc(sizeof(char) * UDF_NAME_LEN, GFP_KERNEL);
> + fname = kmalloc(sizeof(char) * UDF_NAME_LEN, GFP_KERNEL);
> +
> + if (!name || !fname) {
> + *err = -ENOMEM;
> + return NULL;
> + }
> +
> if (dentry) {
> if (!dentry->d_name.len) {
> *err = -EINVAL;

this bit is missing i think:

if (name)
kfree(name);
if (fname)
kfree(fname);

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/