Re: [PCI] duplicate sysfs symbols getting registered in current git

From: Guennadi Liakhovetski
Date: Wed Feb 27 2008 - 07:33:35 EST


On Wed, 27 Feb 2008, Cornelia Huck wrote:

> On Wed, 27 Feb 2008 12:24:54 +0100 (CET),
> Guennadi Liakhovetski <g.liakhovetski@xxxxxx> wrote:
>
> > Ok, result #1: kernel panic
> > http://home.arcor.de/g.liakhovetski/ap400/imga0045.jpg. If necessary, can
> > try a serial console, but that would be more difficult.
>
> Looking at device_add(): Does the following patch make the oops go away?

You mean the kernel panic without CONFIG_SYSFS_DEPRECATED? No,
unfortunately is doesn't.

Thanks
Guennadi

>
> ---
> drivers/base/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-2.6.orig/drivers/base/core.c
> +++ linux-2.6/drivers/base/core.c
> @@ -780,7 +780,7 @@ int device_add(struct device *dev)
> dev = get_device(dev);
> if (!dev || !strlen(dev->bus_id)) {
> error = -EINVAL;
> - goto Error;
> + goto Done;
> }
>
> pr_debug("device: '%s': %s\n", dev->bus_id, __FUNCTION__);
>

---
Guennadi Liakhovetski
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/