Re: [PCI] duplicate sysfs symbols getting registered in current git

From: Cornelia Huck
Date: Wed Feb 27 2008 - 08:21:23 EST


On Wed, 27 Feb 2008 13:33:13 +0100 (CET),
Guennadi Liakhovetski <g.liakhovetski@xxxxxx> wrote:

> You mean the kernel panic without CONFIG_SYSFS_DEPRECATED? No,
> unfortunately is doesn't.

Hm, dev->kobj.parent may be NULL in cleanup_device_parent(). Does this
one help?

---
drivers/base/core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

--- linux-2.6.orig/drivers/base/core.c
+++ linux-2.6/drivers/base/core.c
@@ -621,7 +621,8 @@ static struct kobject *get_device_parent
static void cleanup_glue_dir(struct device *dev, struct kobject *glue_dir)
{
/* see if we live in a "glue" directory */
- if (!dev->class || glue_dir->kset != &dev->class->class_dirs)
+ if (!glue_dir || !dev->class ||
+ glue_dir->kset != &dev->class->class_dirs)
return;

kobject_put(glue_dir);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/