Re: [PATCH] [x86] rdc321x: Kconfig options fixes for rdc321x

From: Ingo Molnar
Date: Wed Feb 27 2008 - 10:06:25 EST



* Florian Fainelli <florian.fainelli@xxxxxxxxxxxxx> wrote:

> Hi Ingo,
>
> Le mercredi 27 février 2008, Ingo Molnar a écrit :
> > these many special conditions in the Kconfig space are way too ugly.
> > (Also, i can see no reason why for example hibernation wouldnt be
> > possible on rdc321x, it's a pure software concept ...)
>
> I would have thought an embedded device with only flash memory as rom
> storage could not hibertnate.
>
> Maybe we should turn all those special conditions into HAVE_FOO/BAR
> instead ?

no. Just leave those things alone. Obviously, if you dont initiate
hibernation it wont be done - and you dont have to build it in either.
But there's no fundamental reason that it _couldnt_ work - if a suitable
device was attached. Dont put such hardcoded dependencies into the
kernel ...

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/