RE: [PATCH] [resend]The kernel gets no IP from some DHCP servers, 2.6.24

From: Wappler Marcel
Date: Wed Feb 27 2008 - 12:26:04 EST


-----Original Message-----
>> In my opinion it is necessary to distinguish between INADDR_ANY and
>> the ZERO address which ist requested to be in the DHCPDISCOVER packet.
>Just delete the lines and the address will be zero because of earlier memset().

>From my personal point of view it is important to document the requirement of the
two addresses to be 0.0.0.0 either through the code itself or through a comment
which states clear the side effect of memset'ting the structure.

Both roads lead to Rome :-)

Marcel
--
Marcel Wappler
Bridgeco AG
CH-8600 Dübendorf
Switzerland
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/