Re: [PATCH 8/9] fs/ocfs2/aops.c: Correct use of ! and &

From: Mark Fasheh
Date: Wed Feb 27 2008 - 16:27:30 EST


On Tue, Feb 26, 2008 at 09:45:56PM +0100, Julia Lawall wrote:
> From: Julia Lawall <julia@xxxxxxx>
>
> In commit e6bafba5b4765a5a252f1b8d31cbf6d2459da337, a bug was fixed that
> involved converting !x & y to !(x & y). The code below shows the same
> pattern, and thus should perhaps be fixed in the same way.
>
> This is not tested and clearly changes the semantics, so it is only
> something to consider.

That looks fine - it's in Ocfs2.git now, thanks.
--Mark

--
Mark Fasheh
Principal Software Developer, Oracle
mark.fasheh@xxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/