Re: [patch 1/2] add ALL_CPUS option to stop_machine_run()

From: Ingo Molnar
Date: Fri Feb 29 2008 - 04:02:01 EST



* Max Krasnyanskiy <maxk@xxxxxxxxxxxx> wrote:

>> -allow stop_mahcine_run() to call a function on all cpus. Calling
>> stop_machine_run() with a 'ALL_CPUS' invokes this new behavior.
>> stop_machine_run() proceeds as normal until the calling cpu has
>> invoked 'fn'. Then, we tell all the other cpus to call 'fn'.
>
> Jason, we're actually trying to reduce the usage of the stop_machine
> in general. [...]

please talk in your own name. Stop-machine is a very elegant tool that
simplifies a lot of hard things in the kernel and is reasonably fast as
well. We've just recently added two new usages of it and more are
planned.

_you_ might be the one who wants to 'reduce the usage of stop_machine' -
but that means it is _you_ who first has to convert a number of very
difficult pieces of code to "something else".

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/