Re: [PATCH] x86/visws: fix printk format warnings

From: Andrey Panin
Date: Fri Feb 29 2008 - 13:17:17 EST


On 042, 02 11, 2008 at 10:05:09AM -0800, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
>
> Fix visws printk format warnings:
>
> /local/linsrc/linux-2.6.24-git15/arch/x86/mach-visws/traps.c:50: warning: format '%#lx' expects type 'long unsigned int', but argument 2 has type 'u32'
> /local/linsrc/linux-2.6.24-git15/arch/x86/mach-visws/traps.c:50: warning: format '%#lx' expects type 'long unsigned int', but argument 3 has type 'u32'
>
> Signed-off-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
> ---
> arch/x86/mach-visws/traps.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> --- linux-2.6.24-git15.orig/arch/x86/mach-visws/traps.c
> +++ linux-2.6.24-git15/arch/x86/mach-visws/traps.c
> @@ -46,8 +46,9 @@ static __init void cobalt_init(void)
> */
> set_fixmap(FIX_APIC_BASE, APIC_DEFAULT_PHYS_BASE);
> setup_local_APIC();
> - printk(KERN_INFO "Local APIC Version %#lx, ID %#lx\n",
> - apic_read(APIC_LVR), apic_read(APIC_ID));
> + printk(KERN_INFO "Local APIC Version %#x, ID %#x\n",
> + (unsigned int)apic_read(APIC_LVR),
> + (unsigned int)apic_read(APIC_ID));
>
> set_fixmap(FIX_CO_CPU, CO_CPU_PHYS);
> set_fixmap(FIX_CO_APIC, CO_APIC_PHYS);

Sorry for so late answer, I missed your mail somehow :(

Acked-By: Andrey Panin <pazke@xxxxxxxxx>

--
Andrey Panin | Linux and UNIX system administrator
pazke@xxxxxxxxx | PGP key: wwwkeys.pgp.net

Attachment: signature.asc
Description: Digital signature