Re: [stable] [PATCH] x86_64 ia32 syscall restart fix

From: Greg KH
Date: Sat Mar 01 2008 - 00:54:39 EST


On Fri, Feb 29, 2008 at 10:20:14PM +0100, Ingo Molnar wrote:
>
> * Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> > I believe the -stable guys have a bot which trolls the mainline
> > commits mailing list for "cc:.*stable@xxxxxxxxxx". So anybody
> > anywhere in the patch delivery chain can append "Cc:
> > <stable@xxxxxxxxxx>" and things should get appropriate consideration.
>
> ok, didnt know about that.

Yes, it's quite handy, so just add that to your patch and we
automatically grab it.

I've added that info to the stable rules file in Documentation, should I
"announce" it anywhere else?

> > The place where I suspect there is a lot of lossage is people simply
> > not thinking about whether a fix should be backported. I'm forever
> > fussing about that for the patches I handle (and I still miss some)
> > but I have a suspicion that not all tree-owners do this fully.
>
> we watch out for this, but still, about 50% of the cases, the
> realization "this should be backported" comes later on. Often because
> fixes get applied with low latency, and testers lag in realizing that
> some particular -stable problem is fixed by a -git fix. Sometimes people
> do bisection in search of backportable fixes - that too has a lag.
>
> so the more formal:
>
> Backport-suggested-by: commit-id, person

I normally just add the person who suggested the patch to be added to
the Cc: if they are not already on the signed-off-by: list.

Does it really matter who suggested that -stable pick it up?

>
> entry would solve both cases. Also, a commit entry in -stable:
>
> Backported-from: commit-id

We already add that info to the commit, but not necessarily in a
"standard" format. If you want it in something like this, it's trivial
to provide it.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/