Re: [PATCH][fs/cifs/cifsfs.c] Make use of cifs_xquota_get

[Steve French]

There are quite a few fixes stuck in cifs-2.6.git that are fine to be
merged with mainline but didn't want to bug Linus with multiple merge
requests (there are a couple of more fixes that are not in
cifs-2.6.git pending review)

On Sat, Mar 1, 2008 at 3:37 AM, Adrian Bunk <bunk@xxxxxxxxxx> wrote:
>
> On Mon, Feb 11, 2008 at 06:46:51PM +0100, Roel Kluin wrote:
>  > Functions cifs_xquota_set and cifs_xquota_get at respectively
>  > fs/cifs/cifsfs.c:367 and 392 are entirely similar - except for
>  > whitespace
>  >
>  > struct quotactl_ops contains function pointers .set_xquota and
>  > .get_xquota that both get the address of cifs_xquota_set.
>  > cifs_xquota_get isn't called anywhere else in the kernel.
>  >
>  > The patch below makes use of the function cifs_xquota_get, As
>  > an alternative the entire function cifs_xquota_get could be
>  > removed.
>  > ---
>  > Make use of cifs_xquota_get
>  >
>  > Signed-off-by: Roel Kluin <12o3l@xxxxxxxxxx>
>  > ---
>  > diff --git a/fs/cifs/cifsfs.c b/fs/cifs/cifsfs.c
>  > index fcc4342..339b829 100644
>  > --- a/fs/cifs/cifsfs.c
>  > +++ b/fs/cifs/cifsfs.c
>  > @@ -461,7 +461,7 @@ int cifs_xstate_get(struct super_block *sb, struct fs_quota_stat *qstats)
>  >
>  >  static struct quotactl_ops cifs_quotactl_ops = {
>  >       .set_xquota     = cifs_xquota_set,
>  > -     .get_xquota     = cifs_xquota_set,
>  > +     .get_xquota     = cifs_xquota_get,
>  >       .set_xstate     = cifs_xstate_set,
>  >       .get_xstate     = cifs_xstate_get,
>  >  };
>
>  Steve, this obvious bugfix seems to be stuck in cifs-2.6.git.
>
>  Can you forward this fix (and other fixes if you have any) to Linus soon?
>
>  TIA
>  Adrian
>
>  --
>
>        "Is there not promise of rain?" Ling Tan asked suddenly out
>         of the darkness. There had been need of rain for many days.
>        "Only a promise," Lao Er said.
>                                        Pearl S. Buck - Dragon Seed
>
>
>



-- 
Thanks,

Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/