Re: [PATCH] firewire: reread config ROM when device reset the bus

From: Kristian HÃgsberg
Date: Mon Mar 03 2008 - 12:38:19 EST


On Mon, Mar 3, 2008 at 11:51 AM, Stefan Richter
<stefanr@xxxxxxxxxxxxxxxxx> wrote:
...
> Maybe I should rather use fw-device.c::idr_rwsem instead of device.sem,
> to have better control over who takes the mutex when. Could also be a
> new dedicated mutex but we don't want to end up with too many of them...
> Do you have an opinion?

Using the struct device mutex is fine, and it parallelizes better than
the global idr_mutex (FWIW). The only concern I have there is that
the device core structs seem to change now and then, and it's not
clear what is implementation details and what is exported for drivers
to use (eg the subsystem sem).

cheers,
Kristian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/