Re: [PATCH 11/17] Add memory mapping driver to RapidIO.
From: Stephen Rothwell
Date: Tue Mar 04 2008 - 05:37:54 EST
On Wed, 5 Mar 2008 00:29:56 +0800 Zhang Wei <wei.zhang@xxxxxxxxxxxxx> wrote:
>
> + if (!(rmem->virt = dma_alloc_coherent(NULL, rmem->size,
> + &rmem->iores.start, GFP_KERNEL))) {
Please separate assignments from tests.
> + if ((ret = rio_space_claim(rmem))) {
Again.
--
Cheers,
Stephen Rothwell sfr@xxxxxxxxxxxxxxxx
http://www.canb.auug.org.au/~sfr/
Attachment:
pgp00000.pgp
Description: PGP signature