Re: WARNING: at drivers/usb/host/ehci-hcd.c:287

From: David Brownell
Date: Tue Mar 04 2008 - 19:30:32 EST


On Tuesday 04 March 2008, Christian Kujau wrote:
> On Tue, 4 Mar 2008, David Brownell wrote:
> >>> Or bettter yet, just removing it entirely. ISTR doing that in some
> >>> patches I've not yet sent for merging, and expect that's what my
> >>> preferred fix will be ...
> >>
> >> But removing the WARN_ON won't fix the problem.
> >
> > It fully resolves the $SUBJECT problem. :)
>
> ...and if it's a safe thing to do, I'm happy with it. I really have no
> clue why shutting up a WARN_ON has no (future) implications but if you
> say so I trust you :)

Carrying that WARN_ON forward was inappropriate, so
removing it is a safe thing to do.

There are other lurking issues though.

- Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/