Re: [PATCH 1/9] scsi: replace __inline with inline

[Adrian Bunk]

On Tue, Mar 04, 2008 at 05:17:16PM -0800, Harvey Harrison wrote:
>...
> --- a/drivers/scsi/aic7xxx/aic79xx_core.c
> +++ b/drivers/scsi/aic7xxx/aic79xx_core.c
> @@ -268,7 +268,7 @@ static int		ahd_match_scb(struct ahd_softc *ahd, struct scb *scb,
>  
>  /******************************** Private Inlines *****************************/
>  
> -static __inline void
> +static inline void
>  ahd_assert_atn(struct ahd_softc *ahd)
>  {
>  	ahd_outb(ahd, SCSISIGO, ATNO);
>...

inline's in .c files in the kernel are in 99,9% of all cases the wrong 
thing, so when you anyway touch this code you cold as well remove them.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/