Re: [RFC][PATCH] PM: Make PM core handle device registrations concurrent with suspend/hibernation

[Rafael J. Wysocki]

On Thursday, 6 of March 2008, Alan Stern wrote:
> On Thu, 6 Mar 2008, Rafael J. Wysocki wrote:
> 
> > > > Revised patch below.
> > > 
> > > It looks good.  Let's hope it doesn't mess up ACPI too badly...  :-)
> > > 
> > > Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> > 
> > Thanks!
> 
> I thought of one more thing you might want to add: device_pm_add() 
> doesn't handle the case where dev->parent is NULL.

I'm not sure what you mean.

If dev->parent is NULL, we get into the "successful" branch where the device is
added to dpm_active.  Do you think we should add any extra handling of this
case?

> You could put in that static "all_devices_sleeping" flag, which gets set at
> the end of dpm_suspend() and cleared at the start of dpm_resume().

Well, I don't think it's necessary.  dpm_active is empty in that case and
we can use the list_empty(&dpm_active) check instead.

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/