Re: [rfc][patch 1/3] slub: fix small HWCACHE_ALIGN alignment

From: Christoph Lameter
Date: Thu Mar 06 2008 - 17:53:42 EST


On Thu, 6 Mar 2008, Nick Piggin wrote:

> > That was due to SLUB's support for smaller allocation sizes. AFAICT has
> > nothing to do with alignment.
>
> The smaller sizes meant objects were less often aligned on cacheline
> boundaries.

Right since SLAB_HWCACHE_ALIGN does not align for very small objects.

> We could, but I'd rather just use the flag.

Do you have a case in mind where that would be useful? We had a
SLAB_HWCACHE_MUST_ALIGN or so at some point but it was rarely to never
used. Note that there is also KMEM_CACHE which picks up the alignment from
the compiler.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/