Re: [UPDATED v3][PATCH 5/7] regulator: sysfs ABI

[Liam Girdwood]

On Fri, 2008-03-07 at 17:13 -0800, David Brownell wrote:
> On Thursday 06 March 2008, Liam Girdwood wrote:
> 
> > +What:		/sys/class/regulator/.../microvolts
> > +	...
> > +
> > +What:		/sys/class/regulator/.../microamps
> > +	...
> 
> Versus Documentation/hwmon/sysfs-interface which uses
> millivolts and milliamperes respectively.
> 
> Why not adopt the same convention?  (This applies to
> many attributes, not just these two.)
> 

I originally had milli but changed to micro to conform with
power_supply.h (as our PMIC uses this interface to export it input
supplies to userspace).

> 
> Also, I'm kind of curious what you've thought about
> power budgeting.  Example, a power supply ("regulator")
> may be able to supply a voltage within a given range,
> but only up to a maximum of 200 mA worth.
> 
> The model visible through these sysfs attributes seems to
> be an either/or thing ... either regulating voltage, or
> current, but not addressing the corresponding constraints
> on the other one.
> 

In general it's up to the system hardware designer to ensure each
regulator can supply all the consumers on the domain - hence we don't
have power budgeting in software atm. However, I don't think it would be
too difficult to add in the future.

I'll also add support for a regulator that will do both voltage and
current (although I'm not aware of any in the market atm).

> 
> > +               NOTE: this will return the string 'constraint not defined'
> 
> How about just "undefined" for all those min/max values?
> 

Agreed.

> 
> > +What:		/sys/class/regulator/.../requested_microamps
> > +	...
> 
> Ditto re "milli" vs "micro".  Also, "requested" seems a bit opaque.
> As a sum, maybe "total_mi{lli,cro}amps" would be more explanatory.
> 

Ok, total_ sounds good.

Liam

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/