Re: [PATCH 1/4] gxfb: Replace FBSIZE config option with a kernelargument

[Andres Salomon]

On Wed, 27 Feb 2008 19:58:39 -0500
Andres Salomon <dilinger@xxxxxxxxxx> wrote:

> On Wed, 27 Feb 2008 16:31:05 -0800
> Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> 
> > On Sat, 23 Feb 2008 01:10:45 -0500
> > Andres Salomon <dilinger@xxxxxxxxxx> wrote:
> > 
> > > @@ -425,7 +424,10 @@ static int __init gxfb_setup(char *options)
> > >  		if (!*opt)
> > >  			continue;
> > >  
> > > -		mode_option = opt;
> > > +		if (!strncmp(opt, "fbsize:", 7))
> > > +			fbsize = simple_strtoul(opt+7, NULL, 0);
> > > +		else
> > > +			mode_option = opt;
> > >  	}
> > 
> > The above shouldn't be necessary.
> 
> It looks like that's done in other drivers in case MODULE isn't defined.  I'm
> assuming this is historical at this point, and manual options parsing can
> be removed from all fb drivers at this point, or is there another reason
> why manual parsing would be necessary?
> 


Could I get an answer from the fbdevel folks about this?  It looks like
the fb_get_options stuff is there for backwards compatibility.
gxfb.fbsize=16777216 (for example) works regardless of whether or not
CONFIG_MODULES is set.  

It would appear that the only reason for fb_get_options() calling would
be to support video=gxfb:<options>.  Is this used any more?  Should it
be marked deprecated, and dropped from the geode fb drivers?


> 
> > 
> > And it should have been documented in Documentation/kernel-parameters.txt.
> 
> Yeah, I wasn't actually sure about that; I did check for other fb drivers
> documenting stuff in kernel-parameters.txt, and didn't see it.  It looks
> like they instead document stuff in Documentation/fb/.  Which is preferred?
> 


I'd also like an opinion about this.


> 
> 
> > 
> > And "fbsize=N" would be a lot more conventional than "fbsize:N"
> > 
> 
> I can certainly change that.  Regarding convention, I toyed with renaming
> it 'vram' (as most of the fb drivers use that), and will probably do
> that unless Jordan objects.
> 
> 
> > I suspect that the formulation you have here will not permit "fbsize:128k",
> > whereas "fbsize=128k" or "gxfb.fbsize=128k" should work.  Needs checking.
> > 
> > >  	return 0;
> > > @@ -456,5 +458,8 @@ module_exit(gxfb_cleanup);
> > >  module_param(mode_option, charp, 0);
> > >  MODULE_PARM_DESC(mode_option, "video mode (<x>x<y>[-<bpp>][@<refr>])");
> > >  
> > > +module_param(fbsize, int, 0);
> > > +MODULE_PARM_DESC(fbsize, "video memory size");
> > > +
> > 
> > Because the module_param() already makes fbsize available on the kernel
> > boot command line via gxfb.fbsize=42 (or something similar).
> > 
> > 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/