Re: [PATCH] x86: Don't send RESCHEDULE_VECTOR to offlined cpus

[Roel Kluin]

Gautham R Shenoy wrote:
> On Mon, Mar 10, 2008 at 01:24:18PM +0100, Ingo Molnar wrote:
>> * Gautham R Shenoy <ego@xxxxxxxxxx> wrote:
>>
>>> x86: Don't send RESCHEDULE_VECTOR to offlined cpus.
>>> From: Gautham R Shenoy <ego@xxxxxxxxxx>
>>>
>>> In the x86 native_smp_send_reschedule_function(), don't send the IPI 
>>> if the cpu has gone offline already. Warn nevertheless!!
>> have you seen this happen?
> 
> Yup, this afternoon while running
> cpu-hotplug stress tests (http://lkml.org/lkml/2008/3/3/11)
> in parallel with kern-bench, I got this on the serial console.

from arch/m32r/kernel/smp.c:134

void smp_send_reschedule(int cpu_id)
{
        WARN_ON(cpu_is_offline(cpu_id));
        send_IPI_mask(cpumask_of_cpu(cpu_id), RESCHEDULE_IPI, 1);
}

should this be changed as well?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/