Re: [RFC, PATCH] signals: print_fatal_signal: fix the signr "calculation"

From: Roland McGrath
Date: Mon Mar 10 2008 - 22:19:42 EST


> For various reasons we can't currently do the same for sig_kernel_coredump()
> signals. But, when rlim[RLIMIT_CORE] == 0, we don't actually need coredumping?
> So, we could do something like
>
>
> - if (!sig_kernel_coredump(sig)) {
> + if (!sig_kernel_coredump(sig) || !signal->rlim[RLIMIT_CORE]) {

I don't like this. I think it's better to leave logic like RLIMIT_CORE
checks to the core dump code itself.


Thanks,
Roland
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/