Re: [PATCH] tty_ioctl: Soft carrier handling

[Alan Cox]

> > +	int bit = arg ? CLOCAL : 0;
> > +	struct ktermios old = *tty->termios;
> 
> Maybe a dumb question, but shouldn't be the snapshot done in the critical 
> section too?

Yes it should. I'll fix that in the next bits and double check the cases
Andrew asks about (although I think they are ok with caller locking from
memory)

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/