Re: [PATCH] x86: parocessor.h - use PAGE_SIZE instead of numericconstant

From: H. Peter Anvin
Date: Wed Mar 12 2008 - 17:11:56 EST


Cyrill Gorcunov wrote:
This patch replaces numeric constant with an appropriate macro

Signed-off-by: Cyrill Gorcunov <gorcunov@xxxxxxxxx>

---

Index: linux-2.6.git/include/asm-x86/processor.h
===================================================================
--- linux-2.6.git.orig/include/asm-x86/processor.h 2008-02-20 19:14:57.000000000 +0300
+++ linux-2.6.git/include/asm-x86/processor.h 2008-03-12 23:10:02.000000000 +0300
@@ -786,7 +786,7 @@ extern unsigned long thread_saved_pc(str
/*
* User space process size. 47bits minus one guard page.
*/
-#define TASK_SIZE64 (0x800000000000UL - 4096)
+#define TASK_SIZE64 (0x800000000000UL - PAGE_SIZE)
/* This decides where the kernel will search for a free chunk of vm
* space during mmap's.

Although I'd personally prefer ((1UL << 47) - PAGE_SIZE)

-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/