Re: [PATCH 1/2] signals: fold sig_ignored() into handle_stop_signal()

From: Roland McGrath
Date: Wed Mar 12 2008 - 17:59:01 EST


This one looks fine to me. I would like the comment above the function to
be updated to describe its new purpose, and to document its return value's
meaning.

Also, I'm not sure if there is a kernel code formatting convention that
particularly excludes an empty block ({}, equiv to ;) containing just
comments. But I don't recall seeing that style used in the kernel.
(I don't mind it personally for this case given what the obvious
alternatives would look like.)


Thanks,
Roland

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/