RE: [PATCH] Fix fsldma.c warning messages when it's compiled underPPC64.

From: Zhang Wei
Date: Thu Mar 13 2008 - 02:53:15 EST


Hi, Dan,

I just consider if it could be reused on Freescale's 64bit processor in the future.
If we don't care this, I can let the driver only depends on PPC32.

diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
index 27340a7..449c0ae 100644
--- a/drivers/dma/Kconfig
+++ b/drivers/dma/Kconfig
@@ -39,7 +39,7 @@ config INTEL_IOP_ADMA

config FSL_DMA
bool "Freescale MPC85xx/MPC83xx DMA support"
- depends on PPC
+ depends on PPC32
select DMA_ENGINE
---help---
Enable support for the Freescale DMA engine. Now, it support

Thanks!
Wei.

> -----Original Message-----
> From: dan.j.williams@xxxxxxxxx
>
> On Tue, Mar 11, 2008 at 7:10 PM, Zhang Wei
> <Wei.Zhang@xxxxxxxxxxxxx> wrote:
> > The reason is the val will be assigned to SR register, and
> SR register
> > is a 32-bit only register.
>
> If this is the case then why not disable the driver for PPC_64?
>
> diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
> index 27340a7..89db937 100644
> --- a/drivers/dma/Kconfig
> +++ b/drivers/dma/Kconfig
> @@ -40,6 +40,7 @@ config INTEL_IOP_ADMA
> config FSL_DMA
> bool "Freescale MPC85xx/MPC83xx DMA support"
> depends on PPC
> + depends on !PPC_64
> select DMA_ENGINE
> ---help---
> Enable support for the Freescale DMA engine. Now, it support
>
> --
> Dan
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/