Re: 2.6.25-rc2 Regression Thinkpad acpi

[Jens Axboe]

On Wed, Mar 12 2008, Henrique de Moraes Holschuh wrote:
> On Wed, 12 Mar 2008, Lukas Hejtmanek wrote:
> > On Wed, Mar 12, 2008 at 07:52:41PM +0100, Arkadiusz Miskiewicz wrote:
> > > I'm also seeing regression on my thinkpad z60m where with git tree (tested 
> > > again with 2 days old git) "thinkvantage" button stopped working (pressing it 
> > > was previously seen by some userspace kde which run konsole).
> > > 
> > > On 2.6.24 presses are seen.
> > 
> > well, on 2.6.25-rc4, some keys are not reported as input (xev does not see any
> > key press), some keys are. Is this desired? Or all the keys (fn+f1-12 + volume
> > + backlight + think vantage) should be reported as some input event and thus
> > acpid makes no sense any more?
> 
> xev has to get events from somewhere.  That somewhere happens to be a buggy
> mess right now (X.org evdev device).  Or it is getting it through some other
> middleware, like HAL, which can have its own problems.
> 
> If you want to test thinkpad-acpi functionality, get HAL and X.org out of
> the way.  The easiest way is to do it in single user mode.

And lets now get back to reality - the reality that now breaks the
previously working setup of lots of users. So you are telling me that in
order to get my volume key functionality back I have to get rid of HAL
and X?

Lets turn back time a bit. Why was this change made? IOW, what was the
reason for breaking a working setup for lots of users? It better be a
damn good reason, or I would heavily argue for reverting this change so
that 2.6.25 actually WORKS as expected for thinkpad users.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/