Re: [PATCH 7/8] Remove current_tick_length()

From: Roman Zippel
Date: Fri Mar 14 2008 - 23:32:39 EST


Hi,

On Fri, 14 Mar 2008, john stultz wrote:

> On Fri, 2008-03-14 at 19:40 +0100, zippel@xxxxxxxxxxxxxx wrote:
> > plain text document attachment (tick_length)
> > current_tick_length used to do a little more, but now it just returns
> > tick_length, which we can also access directly at the few places, where
> > it's needed.
> >
> > Signed-off-by: Roman Zippel <zippel@xxxxxxxxxxxxxx>
>
> Hrm. I'm not sure I like using a global variable instead of using an
> accessor function. At least with the accessor function folks couldn't
> just tweak the value outside ntp as easily.

Why would someone do something silly like this?

> Is there any additional rational for this change?

Useless bloat?

bye, Roman
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/