Re: [PATCH 1/5] split clocksource adjustment from clockosurce mult

[Roman Zippel]

Hi,

On Fri, 14 Mar 2008, john stultz wrote:

> @@ -179,7 +181,7 @@ static inline cycle_t clocksource_read(struct clocksource *cs)
>  static inline s64 cyc2ns(struct clocksource *cs, cycle_t cycles)
>  {
>  	u64 ret = (u64)cycles;
> -	ret = (ret * cs->mult) >> cs->shift;
> +	ret = (ret * (cs->mult + cs->mult_adj)) >> cs->shift;
>  	return ret;
>  }

This add an extra memory access and extra instruction to a code path, we 
should keep as short as possible.
I'd rather add a mult_raw or mult_org and use that for your next patch.

bye, Roman
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/