Re: ACPI lockdep warning on boot, 2.6.25-rc5

[Pavel Machek]

Hi!

> @@ -421,7 +423,9 @@
>  		else
>  			acpi_safe_halt();
>  
> -		local_irq_enable();
> +		if (irqs_disabled())
> +			local_irq_enable();
> +
>  		return;
>  	}
>  
> @@ -530,7 +534,9 @@
>  		 *       skew otherwise.
>  		 */
>  		sleep_ticks = 0xFFFFFFFF;
> -		local_irq_enable();
> +		if (irqs_disabled())
> +			local_irq_enable();
> +
>  		break;
>  
>  	case ACPI_STATE_C2:

That's pretty ugly. Could the code be modified to have interrupt
consistent at this point?

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/