Re: Linux 2.6.25-rc4

[Alan Cox]

O> @@ -462,8 +462,7 @@ static ide_startstop_t ide_ata_error(ide_drive_t *drive, struct request *rq, u8
>  		}
>  	}
>  
> -	if ((stat & DRQ_STAT) && rq_data_dir(rq) == READ &&
> -	    (hwif->host_flags & IDE_HFLAG_ERROR_STOPS_FIFO) == 0)
> +	if ((stat & DRQ_STAT) && rq_data_dir(rq) == READ)
>  		try_to_flush_leftover_data(drive);

That is instant system death on some chipsets. The state machine on the
promise for example empties the FIFO and if you touch the data port again
before issuing a command you lock the PCI bus.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/