Re: [PATCH] [11/18] Fix alignment bug in bootmem allocator

[Yinghai Lu]

On Mon, Mar 17, 2008 at 2:27 PM, Yinghai Lu <yhlu.kernel@xxxxxxxxx> wrote:
>
> On Mon, Mar 17, 2008 at 11:52 AM, Yinghai Lu <yhlu.kernel@xxxxxxxxx> wrote:
>  > On Mon, Mar 17, 2008 at 1:56 AM, Andi Kleen <andi@xxxxxxxxxxxxxx> wrote:
>  >  > > only happen when align is large than alignment of node_boot_start.
>  >  >
>  >  >  Here's an updated version of the patch with this addressed.
>  >  >  Please review. The patch is somewhat more complicated, but
>  >  >  actually makes the code a little cleaner now.
>  >  >
>  >  >  -Andi
>  >  >
>  >  >
>  >  >  Fix alignment bug in bootmem allocator
>  >  >
>  >  >
>  >  >  Without this fix bootmem can return unaligned addresses when the start of a
>  >  >  node is not aligned to the align value. Needed for reliably allocating
>  >  >  gigabyte pages.
>  >  >
>  >  >  I removed the offset variable because all tests should align themself correctly
>  >  >  now. Slight drawback might be that the bootmem allocator will spend
>  >  >  some more time skipping bits in the bitmap initially, but that shouldn't
>  >  >  be a big issue.
>  >  >
>  >  >
>  >  >  Signed-off-by: Andi Kleen <ak@xxxxxxx>
>  >  >
>  >  how about create local node_boot_start and node_bootmem_map that make
>  >  sure node_boot_start has bigger alignment than align input.
>
>  please check it
>

please don't use v2... it doesn't work.

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/