Re: [PATCH] de-semaphorize smackfs

From: Christoph Hellwig
Date: Tue Mar 18 2008 - 03:35:44 EST


On Mon, Mar 17, 2008 at 05:14:40PM -0600, Jonathan Corbet wrote:
> While looking at the generic semaphore patch, I came to wonder what the
> remaining semaphore users in the kernel were actually doing. After a
> quick grep for down_interruptible(), smackfs remained at the bottom of
> my screen. It seems like a straightforward mutex case - low-hanging
> fruit. So here's a conversion patch; compile-tested only, but what
> could go wrong?

The lock is kept while returning to userspace and could potentially
be release by another process. This is not allowed for mutexes.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/