Re: [PATCH][v4] Modify loop device to be able to manage partitions of the disk image

From: Bill Davidsen
Date: Thu Mar 20 2008 - 17:37:43 EST


Andrew Morton wrote:
On Wed, 19 Mar 2008 21:24:41 +0100
Laurent Vivier <Laurent.Vivier@xxxxxxxx> wrote:

Le mercredi 19 mars 2008 __ 13:11 -0700, Randy Dunlap a __crit :
On Wed, 19 Mar 2008 13:36:07 +0100 Laurent Vivier wrote:

This patch allows to use loop device with partitionned disk image.

Original behavior of loop is not modified.

A new parameter is introduced to define how many partition we want to be
able to manage per loop device. This parameter is "max_part".
What happened to the update to Documentation/kernel-parameters.txt
that was in v3?
Well, perhaps I didn't understand the comment of Andrew:

"This shouldn't be needed."

I though it means I should remove it. So, Andrew ???

No, given that all module_param() options are available via the boot
command line when the module is linked into vmlinux, we don't document them
separately.

I totally don't understand this comment, where is the file with the list of canonical module parameters now? I must have missed the discussion of why it is changed. And what has the boot command line or linking modules to do with the documentation file?

There should be a way of auto-generating all the documentation for all the
module parameters from their MODULE_PARM_DESC's. And there probably is,
but I'm not sure how this is done (?)

(does `make help', fails to spot it).


--
Bill Davidsen <davidsen@xxxxxxx>
"We have more to fear from the bungling of the incompetent than from
the machinations of the wicked." - from Slashdot
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/